From: tobtoht <thotbot@protonmail.com>
Date: Fri, 11 Mar 2022 15:03:06 +0000 (+0100)
Subject: WebsocketClient: fix potential crash
X-Git-Url: https://git.nutra.tk/v2?a=commitdiff_plain;h=efda5175035902309eba5b8c2a35561942466d69;p=gamesguru%2Ffeather.git

WebsocketClient: fix potential crash
---

diff --git a/src/utils/WebsocketClient.cpp b/src/utils/WebsocketClient.cpp
index 948954a4..2b795a73 100644
--- a/src/utils/WebsocketClient.cpp
+++ b/src/utils/WebsocketClient.cpp
@@ -117,3 +117,9 @@ void WebsocketClient::onbinaryMessageReceived(const QByteArray &message) {
 
     emit WSMessage(object);
 }
+
+WebsocketClient::~WebsocketClient() {
+    // webSocket may fire QWebSocket::disconnected after WebsocketClient is destroyed
+    // explicitly disconnect to prevent crash
+    webSocket.disconnect();
+}
\ No newline at end of file
diff --git a/src/utils/WebsocketClient.h b/src/utils/WebsocketClient.h
index ca53be60..1563f448 100644
--- a/src/utils/WebsocketClient.h
+++ b/src/utils/WebsocketClient.h
@@ -15,6 +15,7 @@ class WebsocketClient : public QObject {
 
 public:
     explicit WebsocketClient(QObject *parent = nullptr);
+    ~WebsocketClient() override;
     void start();
     void restart();
     void stop();