lint fixes

diff --git a/git-remote-gcrypt b/git-remote-gcrypt
index 8202a41e660d489a4b9f58451d767ec8d8c13d42..334c44c4b8752f1ec3f896148e5084b767414d87 100755 (executable)
--- a/git-remote-gcrypt
+++ b/git-remote-gcrypt
@@ -1422,6 +1422,7 @@ get_remote_file_list()
                                return 1
                        }
                        git update-ref -d "refs/gcrypt/list-files"
+               else
                        # Could not fetch, or remote is empty.
                        # If checking, this might be fine, but for clean it's an issue if we expected files.
                        # Returning 1 is safer.

diff --git a/install.sh b/install.sh
index fc909d48a45b4204e16c6e0f79490079b54e5ec6..f410675a76fc223fccfb79195ef430d787f97ded 100755 (executable)
--- a/install.sh
+++ b/install.sh
@@ -15,7 +15,6 @@ if [ -z "${prefix:-}" ]; then
 fi
 : "${DESTDIR:=}"
 
-log() { printf "\033[1;36m[INSTALL] %s\033[0m\n" "$1"; }
 verbose() { echo "$@" >&2 && "$@"; }
 
 install_v() {

diff --git a/tests/test-install-logic.sh b/tests/test-install-logic.sh
index 7518b917d58566aefec5527d7b4e501c23fde312..b1effeb856ecf78c88c86bc14c664430cc726ed0 100755 (executable)
--- a/tests/test-install-logic.sh
+++ b/tests/test-install-logic.sh
@@ -225,7 +225,7 @@ unset DESTDIR
 # We copy the installer (breaking symlink) and patch it to check a nonexistent path instead of /usr/local
 
 rm -f "$INSTALLER"
-sed 's|/usr/local|/non/existent/path|g' "$REPO_ROOT/install.sh" > "$INSTALLER"
+sed 's|/usr/local|/non/existent/path|g' "$REPO_ROOT/install.sh" >"$INSTALLER"
 chmod +x "$INSTALLER"
 
 # Run with PREFIX set but explicit prefix unset

diff --git a/utils/gen_docs.sh b/utils/gen_docs.sh
index b0545107280e2f49e2ffd3ac1cd5b95b8aa0bff1..7e2925651b45e8791bf6dcb23ce4a4fecd81d1b2 100755 (executable)
--- a/utils/gen_docs.sh
+++ b/utils/gen_docs.sh
@@ -50,7 +50,8 @@ CLEAN_FLAGS_ZSH=""
 # Only generate if there are actual flags
 COMMA_FLAGS=$(echo "$CLEAN_FLAGS_BASH" | tr ' ' ',')
 if [ -n "$CLEAN_FLAGS_BASH" ]; then
-       CLEAN_FLAGS_ZSH="'(${CLEAN_FLAGS_BASH})' {${COMMA_FLAGS}} '[flag]'"
+       # zsh _arguments requires format: '(exclusion)'{-f,--long}'[desc]' as ONE string (no spaces)
+       CLEAN_FLAGS_ZSH="'(${CLEAN_FLAGS_BASH})'{${COMMA_FLAGS}}'[flag]'"
 else
        CLEAN_FLAGS_ZSH=""
 fi