From c0c98bb0c088bd9b93c8f2d2c86feb046b647fa9 Mon Sep 17 00:00:00 2001 From: Shane Jaroch Date: Sat, 17 Jan 2026 04:50:05 -0500 Subject: [PATCH] fix coverage, ln not copy! --- Makefile | 5 +---- tests/installer-test-logic.sh | 8 ++++---- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/Makefile b/Makefile index 2b306c6..bb4d81c 100644 --- a/Makefile +++ b/Makefile @@ -178,11 +178,8 @@ CHECK_COVERAGE = $(if $(call find_coverage_xml,$(1)), \ exit 1) -.PHONY: test/cov _test_cov_internal +.PHONY: test/cov test/cov: ##H Show coverage gaps - $(MAKE) _test_cov_internal - -_test_cov_internal: @err=0; \ $(call CHECK_COVERAGE,$(COV_SYSTEM),git-remote-gcrypt,56) || err=1; \ $(call CHECK_COVERAGE,$(COV_INSTALL),install.sh,84) || err=1; \ diff --git a/tests/installer-test-logic.sh b/tests/installer-test-logic.sh index 73b6673..7b03923 100755 --- a/tests/installer-test-logic.sh +++ b/tests/installer-test-logic.sh @@ -19,7 +19,7 @@ print_info "Running install logic tests in $SANDBOX..." # 2. Copy/Symlink artifacts # Copy install.sh so kcov can track it correctly (symlinks confuse kcov) -cp "$REPO_ROOT/install.sh" "$SANDBOX/install.sh" +ln -s "$REPO_ROOT/install.sh" "$SANDBOX/install.sh" ln -s "$REPO_ROOT/git-remote-gcrypt" "$SANDBOX/git-remote-gcrypt" ln -s "$REPO_ROOT/utils" "$SANDBOX/utils" ln -s "$REPO_ROOT/completions" "$SANDBOX/completions" @@ -71,7 +71,7 @@ assert_version() { # --- TEST 1: Strict Metadata Requirement --- echo "--- Test 1: Fail without Metadata ---" rm -rf debian redhat -if "bash" "$INSTALLER" >/dev/null 2>&1; then +if bash "$INSTALLER" >/dev/null 2>&1; then print_err "FAILED: Installer should have exited 1 without debian/changelog" exit 1 else @@ -105,7 +105,7 @@ rm -rf "${SANDBOX:?}/usr" export prefix="$SANDBOX/usr" unset DESTDIR -"bash" "$INSTALLER" >/dev/null 2>&1 || { +bash "$INSTALLER" >/dev/null 2>&1 || { print_err "Installer FAILED" exit 1 } @@ -123,7 +123,7 @@ rm -rf "${SANDBOX:?}/pkg_root" export prefix="/usr" export DESTDIR="$SANDBOX/pkg_root" -"bash" "$INSTALLER" >/dev/null 2>&1 || { +bash "$INSTALLER" >/dev/null 2>&1 || { print_err "Installer FAILED" exit 1 } -- 2.52.0