From: tobtoht <tob@featherwallet.org>
Date: Sun, 12 Feb 2023 02:01:32 +0000 (+0100)
Subject: nodes: clarify useSocks5Proxy
X-Git-Url: https://git.nutra.tk/v1?a=commitdiff_plain;h=31183f7a311473f1c9d1af2a2bab775eb93d5a73;p=gamesguru%2Ffeather.git

nodes: clarify useSocks5Proxy
---

diff --git a/src/utils/nodes.cpp b/src/utils/nodes.cpp
index b1f77278..bcbd26e6 100644
--- a/src/utils/nodes.cpp
+++ b/src/utils/nodes.cpp
@@ -449,26 +449,36 @@ bool Nodes::useI2PNodes() {
 
 bool Nodes::useSocks5Proxy(const FeatherNode &node) {
     if (node.isLocal()) {
+        // When Feather is connected to a local node, ignore proxy settings.
         return false;
     }
 
     if (Utils::isTorsocks()) {
+        // When Feather is started with torsocks, let torsocks handle traffic.
         return false;
     }
 
-    if (TailsOS::detect() || WhonixOS::detect()) {
+    if (config()->get(Config::proxy).toInt() == Config::Proxy::None) {
+        return false;
+    }
+
+    if (TailsOS::detect()) {
+        // Tails does not transparently route traffic over Tor.
+        return true;
+    }
+
+    if (WhonixOS::detect()) {
         return true;
     }
 
     if (config()->get(Config::proxy).toInt() == Config::Proxy::Tor) {
+        // Don't use socks5 proxy if initial sync traffic is excluded.
         return this->useOnionNodes();
     }
 
     if (config()->get(Config::proxy).toInt() != Config::Proxy::None) {
         return true;
     }
-
-    return false;
 }
 
 void Nodes::updateModels() {