lint/tidy

diff --git a/CMakeLists.txt b/CMakeLists.txt
index e5d7ea78d33bab6cf6f072153b949e1be6e8cdcb..3868ffa814746c0dd34df69b390b880422f1151b 100644 (file)
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -13,11 +13,9 @@ set(CMAKE_AUTOUIC ON)
 find_package(QT NAMES Qt6 Qt5 REQUIRED COMPONENTS Widgets Sql)
 find_package(Qt${QT_VERSION_MAJOR} REQUIRED COMPONENTS Widgets Sql)
 
-file(GLOB_RECURSE PROJECT_SOURCES 
-    "src/*.cpp" 
-    "include/*.h"
-    "resources.qrc"
-)
+file(GLOB_RECURSE SOURCES CONFIGURE_DEPENDS "src/*.cpp")
+file(GLOB_RECURSE HEADERS CONFIGURE_DEPENDS "include/*.h")
+set(PROJECT_SOURCES ${SOURCES} ${HEADERS} "resources.qrc")
 
 # Versioning
 if(NOT NUTRA_VERSION)

diff --git a/src/db/databasemanager.cpp b/src/db/databasemanager.cpp
index 95b8ead5fcc71daf9f2423350a45e465a8a0545a..0ffa993848fe255b933a06596bf7aec0c6416975 100644 (file)
--- a/src/db/databasemanager.cpp
+++ b/src/db/databasemanager.cpp
@@ -20,6 +20,9 @@ DatabaseManager::~DatabaseManager() {
     if (m_db.isOpen()) {
         m_db.close();
     }
+    if (m_userDb.isOpen()) {
+        m_userDb.close();
+    }
 }
 
 bool DatabaseManager::isValidNutraDatabase(const QSqlDatabase& db) {

diff --git a/src/db/foodrepository.cpp b/src/db/foodrepository.cpp
index 2a713462aef35ca77354997994245ed0d557b75d..05d4d328407982d4d2a33c9642120567e0da25aa 100644 (file)
--- a/src/db/foodrepository.cpp
+++ b/src/db/foodrepository.cpp
@@ -248,9 +248,11 @@ void FoodRepository::updateRda(int nutrId, double value) {
     if (!userDb.isOpen()) return;
 
     QSqlQuery query(userDb);
-    query.prepare(
-        "INSERT OR REPLACE INTO rda (profile_id, nutr_id, rda) "
-        "VALUES (1, ?, ?)");
+    if (!query.prepare("INSERT OR REPLACE INTO rda (profile_id, nutr_id, rda) "
+                       "VALUES (1, ?, ?)")) {
+        qCritical() << "Failed to prepare RDA update:" << query.lastError().text();
+        return;
+    }
     query.bindValue(0, nutrId);
     query.bindValue(1, value);
 

diff --git a/src/db/mealrepository.cpp b/src/db/mealrepository.cpp
index eba807817ef254af8e4dad949853bbfa61710ba8..77a492fdd877180242d847cb59698fdeff3b32f4 100644 (file)
--- a/src/db/mealrepository.cpp
+++ b/src/db/mealrepository.cpp
@@ -148,5 +148,8 @@ void MealRepository::removeLogEntry(int logId) {
     QSqlQuery query(db);
     query.prepare("DELETE FROM log_food WHERE id = ?");
     query.addBindValue(logId);
-    query.exec();
+    query.addBindValue(logId);
+    if (!query.exec()) {
+        qCritical() << "Failed to remove log entry:" << query.lastError().text();
+    }
 }