fix: allow access to root-level issues in schema-less forms (#14893)

* fix: allow access to root-level issues in schema-less forms

* feat: use IsAny type to account for `f7` test

* include `allIssues()`

* simplify type

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
* Update types

---------

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>

diff --git a/.changeset/every-bears-clean.md b/.changeset/every-bears-clean.md
new file mode 100644 (file)
index 0000000..8463211
--- /dev/null
+++ b/.changeset/every-bears-clean.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/kit': patch
+---
+
+fix: allow access to root-level issues in schema-less forms

diff --git a/packages/kit/src/exports/public.d.ts b/packages/kit/src/exports/public.d.ts
index 21ed3e6cda0006c08a5c150a40afb94ed1921d69..5bc86276b4f524ff6b183eca0a52014a48fa13f5 100644 (file)
--- a/packages/kit/src/exports/public.d.ts
+++ b/packages/kit/src/exports/public.d.ts
@@ -2075,7 +2075,7 @@ export type RemoteForm<Input extends RemoteFormInput | void, Output> = {
        /** The number of pending submissions */
        get pending(): number;
        /** Access form fields using object notation */
-       fields: Input extends void ? never : RemoteFormFields<Input>;
+       fields: RemoteFormFields<Input>;
        /** Spread this onto a `<button>` or `<input type="submit">` */
        buttonProps: {
                type: 'submit';

diff --git a/packages/kit/test/types/remote.test.ts b/packages/kit/test/types/remote.test.ts
index 760663fa9291ddaf2253da5c84b2aa0c333c77b1..99609c6d16a98258ed24793498f8021aa2f74479 100644 (file)
--- a/packages/kit/test/types/remote.test.ts
+++ b/packages/kit/test/types/remote.test.ts
@@ -341,6 +341,8 @@ function form_tests() {
                        invalid.x('bar')
                );
        });
+       f8.fields.issues();
+       f8.fields.allIssues();
        // @ts-expect-error
        f8.fields.x;
        // @ts-expect-error

diff --git a/packages/kit/types/index.d.ts b/packages/kit/types/index.d.ts
index 35b387405f53fcf56aaf9e865e780f4971075fda..cf87795ed24731d665dc70b5a73c2d45ccb73523 100644 (file)
--- a/packages/kit/types/index.d.ts
+++ b/packages/kit/types/index.d.ts
@@ -2051,7 +2051,7 @@ declare module '@sveltejs/kit' {
                /** The number of pending submissions */
                get pending(): number;
                /** Access form fields using object notation */
-               fields: Input extends void ? never : RemoteFormFields<Input>;
+               fields: RemoteFormFields<Input>;
                /** Spread this onto a `<button>` or `<input type="submit">` */
                buttonProps: {
                        type: 'submit';